Conversation
baptistegrimaud
force-pushed
the
refactor/removed-barrels
branch
from
80f0c8e to
459a0b4
Compare
baptistegrimaud
added a commit
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pure code quality change: removed all
export * from somewherestatements. A file only containing this kind of statement is named a barrel file.Rationale: it's not a good practice.[1][2] (it impacts performance and impairs tools)
Instead, we have a single entry point for our library, with an explicit list of exports; we now fully control the exposed API.
Tests
The following are included in this PR
Checklist
I have considered the following implications of my change:
Documentation